MAHOUT-454 Notebook Testing #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
in it's current implementation- the test fails if any cell in any notebook fails- it is possible w/o much extra effort to layer in a testing framework (ie pytest) but i didn't realize we had that already in, or understand enough about it, i would make "add pytest to notebook tests' a follow on issue |
|
or, discussion point- add tests in pytest for the notebooks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR:
Please give a short description of what this PR is for.
Important ToDos
Please mark each with an "x"
A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
Created unit tests where appropriate
Added licenses correct on newly added files
Assigned JIRA to self
Successfully built and ran all unit tests, verified that all tests pass locally.
If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
Does this change break earlier versions?
Is this the beginning of a larger project for which a feature branch should be made?
Evidence of successful run:
https://github.com/apache/mahout/actions/runs/10724164981